fix: underlined text in homepage cards #400
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgowru
commented
Feb 5, 2025
•
kgowru
commented
- Remove underline on text on https://docs.cohere.com/ home
|
🌿 Preview your docs: https://cohere-preview-bcb46e8e-02df-475a-89d8-5a505a67c98d.docs.buildwithfern.com |
fern-support
approved these changes
Feb 6, 2025
|
🌿 Preview your docs: https://cohere-preview-eea365a3-c756-43e4-a7d5-9a96fe993efe.docs.buildwithfern.com |
invader89
reviewed
Feb 7, 2025
| @@ -32,6 +32,7 @@ export const LandingPageCard = ({ href, title, imgSrc, description }) => ( | |||
| href={href} | |||
| target="_self" | |||
| className="flex h-full flex-col justify-between" | |||
| style={{ textDecoration: 'none' }} | |||
There was a problem hiding this comment.
nit: instead of using inline style we can use tailwind class no-underline, it will also remove text underline
There was a problem hiding this comment.
Tailwind doesn't work in this scenario, there's an issue with tailwind loading. We will fix this at a platform level soon :).
For an immediate fix, this is the only solve!
invader89
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.